[ci] Assert some tests are not skipped in the CI #12915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigiblender
changed the title
gigiblender
force-pushed
the
assert-no-tests-skipped
branch
3 times, most recently
from
9647d80
to
e010e84
Compare
areusch
added
needs-triage
gigiblender
force-pushed
the
assert-no-tests-skipped
branch
2 times, most recently
from
b5bb4f1
to
b1eb3bb
Compare
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
reviewed
Nov 4, 2022
There was a problem hiding this comment.
I don't know if we need to do this right away but ideally this would be part of the singular tvm-bot comment that is generated by tlc-pack/ci#52 eventually
…required_tests_to_run` file are not skipped.
gigiblender
force-pushed
the
assert-no-tests-skipped
branch
from
b1eb3bb
to
62a3c1b
Compare
driazati
approved these changes
Nov 13, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
In this PR, the skipped tests script will also check if tests in the `required_tests_to_run.json` have not been skipped. If there are skipped tests, they will be added to the returned comment. I am not entirely sure where it's best to place the `required_tests_to_run` file, so I left it in `tvm/ci/scripts/`. I am happy to take suggestions. Aims to prevent situations such as apache#12529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the skipped tests script will also check if tests in the
required_tests_to_run.jsonhave not been skipped. If there are skipped tests, they will be added to the returned comment.I am not entirely sure where it's best to place the
required_tests_to_runfile, so I left it intvm/ci/scripts/. I am happy to take suggestions.Aims to prevent situations such as #12529